Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

🔄 Synced file(s) with WordPress/openverse #921

Merged
merged 10 commits into from
Dec 17, 2022

Conversation

openverse-bot
Copy link
Contributor

@openverse-bot openverse-bot commented Dec 13, 2022

Synced local file(s) with WordPress/openverse.

Changed files
  • Synced local .github/workflows/pr_label_check.yml with remote .github/workflows/pr_label_check.yml
  • Synced local directory .github/ISSUE_TEMPLATE/ with remote directory .github/ISSUE_TEMPLATE/
  • Synced local .github/PULL_REQUEST_TEMPLATE.md with remote .github/PULL_REQUEST_TEMPLATE.md
  • Synced local prettier.config.js with remote prettier.config.js.jinja
  • Synced local .pre-commit-config.yaml with remote .pre-commit-config.yaml.jinja

This PR was created automatically by the repo-file-sync-action workflow run #3709078998

@openverse-bot openverse-bot requested a review from a team as a code owner December 13, 2022 21:59
@openverse-bot openverse-bot added 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🤖 aspect: dx Concerns developers' experience with the codebase labels Dec 13, 2022
@openverse-bot openverse-bot force-pushed the repo-sync/openverse/default branch from 66bfc28 to cdb38b0 Compare December 14, 2022 00:21
@openverse-bot openverse-bot force-pushed the repo-sync/openverse/default branch 2 times, most recently from daebfe7 to 2da45be Compare December 14, 2022 02:19
@AetherUnbound
Copy link
Contributor

@stacimc I've run the new prettier linting on our markdown and committed the changes. I also had to make some adjustments to the DAG doc generation steps so that linting is run automatically for a few reasons:

  • The changes prettier wants (like full width calculated tables) are too drastic to try to capture in code when that logic is already something prettier will do for us
  • Prettier wants to rewrite all of the DAG documentation which is present in the docstring for each DAG, which would mean to fix that we'd have to go back to every DAG and apply the changes (which I don't particularly want to do)

Additionally if you can, please try running both just lint locally and just generate-dag-docs to see that everything works okay!

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving an approval because I applied the other fixes 😄

Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ , lint and generate-dag-docs working as expected locally

@openverse-bot openverse-bot force-pushed the repo-sync/openverse/default branch from 99c89d9 to 628bf96 Compare December 15, 2022 00:22
@AetherUnbound
Copy link
Contributor

Okay as annoying as this is, let's wait until #874 is merged to get this in because that has a fix for the permissions issue we're seeing here.

@openverse-bot openverse-bot force-pushed the repo-sync/openverse/default branch from 628bf96 to 984d87f Compare December 16, 2022 00:21
@AetherUnbound AetherUnbound force-pushed the repo-sync/openverse/default branch from 984d87f to 98fa65a Compare December 17, 2022 00:00
@AetherUnbound
Copy link
Contributor

YAY!

Quick, merging before it force pushes again!

@AetherUnbound AetherUnbound merged commit 3979fc2 into main Dec 17, 2022
@AetherUnbound AetherUnbound deleted the repo-sync/openverse/default branch December 17, 2022 00:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants