-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! I have one recommended change. Additionally, it looks like the linting step is failing locally. Do you mind running just lint
locally and committing the changes it recommends?
CONTRIBUTING.md
Outdated
@@ -3,18 +3,21 @@ | |||
Thank you for your interest in contributing to Openverse! This document is | |||
a set of guidelines to help you contribute to this project. | |||
|
|||
Please refer to [CONTRIBUTING.md](https://github.com/WordPress/openverse/blob/0b5e24bd325da7b75db9484a268d7c8d197ae920/CONTRIBUTING.md) for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the link so that it always points to the latest.
Please refer to [CONTRIBUTING.md](https://github.com/WordPress/openverse/blob/0b5e24bd325da7b75db9484a268d7c8d197ae920/CONTRIBUTING.md) for a | |
Please refer to [CONTRIBUTING.md](./CONTRIBUTING.md) for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would point to the file in the openverse-catalog
repo, right? The requirement was to direct users to the main repo, so I put up the entire link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruvkb we intentionally wanted to point to the larger contributing file in the main repo!
Thanks for the direction to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks again @kavyabhat02!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well, thanks :)
Fixes
Fixes WordPress/openverse#1413 by @AetherUnbound
Description
Made improvements to
CONTRIBUTING.md
.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin