-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 💯 confident what "pinned" means here, but I'm assuming that it means when there is a specific version listed in the requirements file. I did try just install
with this branch and it worked fine. 👍 Just one tiny comment.
@@ -0,0 +1,6 @@ | |||
# For local dev tooling only, this is separate from requirements_dev.txt because these | |||
# libraries are not needed within the built docker container in any environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment really made my day, and is extremely helpful.
Co-authored-by: rwidom <[email protected]>
That's exactly it! Unpinned dependencies are those just listed in the file without a version attached to them, meaning that whatever the latest version is (or whatever the constraints dictate) is what gets installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reasoning seems sound to me, this looks good!
Fixes
Fixes WordPress/openverse#1650 by @zackkrida
Description
This PR adds a dependabot configuration to the repository.
Based on my understanding of the dependabot documentation, I believe dependabot will only try to update pinned dependencies. We only pin dependencies in cases where the dependency itself is not defined in the Airflow constraints file. As such I think it should be safe to have dependabot manage the pinned dependencies, since those ones aren't managed by Airflow! I'm not sure how best to test this, we may just need to merge it and find out 😄 Dependabot should be able to handle the 3 different
requirements_*.txt
files we have.I also renamed one of our files from
requirements.txt
torequirements_tooling.txt
to make its purpose clearer.Testing Instructions
just install
locally and make sure it still worksChecklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin