This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Add audio to the Database #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tore Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Refactor `image_store` into `media_store`, `image_store` and `audio_store`
Audio table definition is added to the `local_postgres/03_openledger_media_schema.sql` (renamed from `openledger_image_schema.sql`) Docker executes sql files in alphabetical order, so the numbers were added to .sql file names to ensure correct loading order
Signed-off-by: Olga Bulat <[email protected]>
obulat
force-pushed
the
add_audio_storage
branch
3 times, most recently
from
f08299a to
6b7ba33
Compare
# Conflicts: # src/cc_catalog_airflow/dags/common/storage/audio.py # src/cc_catalog_airflow/dags/common/storage/media.py # src/cc_catalog_airflow/dags/common/storage/test_audio.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to WordPress / openverse # 19
This is a cleaned-up version of #64 related to saving the Audio data to the database.
This PR creates a new Audio database. The ingestion workflow now differs for audio and image tables, and the selection is based on the media_type, which is recorded in the tsv filename.
To finalize this PR, we need to agree on the audio metadata that we are going to save.