Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Upgrade Airflow to v2.3.3 #664

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Upgrade Airflow to v2.3.3 #664

merged 2 commits into from
Aug 16, 2022

Conversation

AetherUnbound
Copy link
Contributor

@AetherUnbound AetherUnbound commented Aug 15, 2022

Fixes

Fixes WordPress/openverse#1489 by @AetherUnbound

Description

This PR upgrades Airflow to v2.3.3, which includes the fix necessary in order to get our Sensors functioning properly. This jump does include a migration, and some important changes regarding the frontend. Fortunately we don't have any specific code related to the frontend, so AFAICT they don't affect us!

I tried running the SMK & Cleveland provider DAGs, as well as both the audio & image data refresh DAGs. I confirmed that all 4 ran successfully and that the latter 2 set the sensors to up_for_reschedule rather than up_for_retry.

Screenshot_2022-08-15_14-17-05

Testing Instructions

Note: You will need to run just build before any testing!

Please double check that you can also run the data refresh DAGs locally, and that the sensor steps go to up_for_reschedule. See above for a picture of what that looks like.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner August 15, 2022 21:26
@openverse-bot openverse-bot added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP labels Aug 15, 2022
Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as well. I tested Jamendo, Science Museum, Wikimedia, and the PR Review reminder DAG. I also tested both data refreshes -- audio went so fast it was hard to catch, but in image I could easily see our sensors go up_for_reschedule! 😄

There is one warning printed when running just test, but it is in the commoncrawl_etl DAG which is not enabled or currently supported:

/usr/local/airflow/openverse_catalog/dags/commoncrawl/commoncrawl_etl.py:172: DeprecationWarning:
              S3PrefixSensor is deprecated.
              Please use `airflow.providers.amazon.aws.sensors.s3.S3KeySensor`.

    check_for_cc_index = S3PrefixSensor(

-- Docs: https://docs.pytest.org/en/stable/warnings.html

@AetherUnbound
Copy link
Contributor Author

Oops, I meant to attach a photo to this and then switched computers 😅 If I'm able to make it back to the other one at some point I'll add it!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the clear local testing instructions.

@AetherUnbound AetherUnbound merged commit f6e8fa0 into main Aug 16, 2022
@AetherUnbound AetherUnbound deleted the bugfix/airflow-2.3.x#639 branch August 16, 2022 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Airflow to >2.3.0
4 participants