Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Renames for Openverse API #98

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Renames for Openverse API #98

merged 5 commits into from
Jun 9, 2021

Conversation

zackkrida
Copy link
Member

@zackkrida zackkrida commented Jun 8, 2021

This PR rewrites the following:

  • Any email address to [email protected]
  • api-dev.creativecommons.engineering ~> dev.api.openverse.engineering
  • api.creativecommons.engineering ~> api.openverse.engineering
  • CC Catalog API ~> Openverse API
  • CC Search ~> Openverse

@zackkrida zackkrida requested a review from a team as a code owner June 8, 2021 17:28
@zackkrida zackkrida requested review from krysal and obulat June 8, 2021 17:28
obulat
obulat previously approved these changes Jun 8, 2021
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

analytics/docs/swagger.yaml Outdated Show resolved Hide resolved
obulat
obulat previously approved these changes Jun 9, 2021
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, just a couple of questions about email addresses inline.

openverse-api/catalog/api/views/site_views.py Outdated Show resolved Hide resolved
openverse-api/catalog/urls.py Outdated Show resolved Hide resolved
@zackkrida zackkrida changed the title URL renames for Openverse API Renames for Openverse API Jun 9, 2021
krysal
krysal previously approved these changes Jun 9, 2021
Signed-off-by: Olga Bulat <[email protected]>
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed a couple of README typos from before, everything else looks good

@zackkrida
Copy link
Member Author

Great thank you both!

@zackkrida zackkrida merged commit 09de5ca into main Jun 9, 2021
@zackkrida zackkrida deleted the rename-urls branch June 9, 2021 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants