Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Removed get_api_exception and replaced with built in DRF exceptions #974

Closed
wants to merge 0 commits into from

Conversation

AbhiYHub
Copy link
Contributor

@AbhiYHub AbhiYHub commented Oct 7, 2022

Fixes

Fixes #843 by @sarayourfriend

Description

In this PR I have done the following: -

  1. Replaced all usages of get_api_exception function with the appropriate built-in DRF exception from rest_framework.exceptions.
  2. Also, for any that are following the try: queryset.get(); except Model.DoesNotExist: ... pattern, replaced it with get_object_or_404.
  3. Removed the get_api_exception function.
  4. Code Cleanup.

Testing Instructions

  • While testing I followed the developer doc and all the test cases passed successfully.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AbhiYHub AbhiYHub requested a review from a team as a code owner October 7, 2022 20:51
@AbhiYHub AbhiYHub requested review from obulat and stacimc October 7, 2022 20:51
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Oct 7, 2022
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, thank you @AbhiYHub. I have one small change I'd like to request but otherwise this looks great to me 🙂

api/catalog/api/views/media_views.py Outdated Show resolved Hide resolved
@AbhiYHub
Copy link
Contributor Author

@sarayourfriend I have raised a new PR by pulling the current changes from the main repo, please review it. I messed in reverting the changes, so I committed once more as last one got closed.

@sarayourfriend
Copy link
Contributor

Sure thing, no worries! Rebasing/merging main in can get messy sometimes 😅

@AbhiYHub
Copy link
Contributor Author

Sure thing, no worries! Rebasing/merging main in can get messy sometimes 😅

Thanks! @sarayourfriend

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove get_api_exception and replace with built in DRF exceptions
3 participants