Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add concurrency settings for workflow #970

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Add concurrency settings for workflow #970

merged 3 commits into from
Oct 12, 2022

Conversation

alrz1999
Copy link
Contributor

@alrz1999 alrz1999 commented Oct 4, 2022

Fixes

Related to openverse #267 by @sarayourfriend

Description

This pull request Adds concurrency settings for workflow

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@alrz1999 alrz1999 requested a review from a team as a code owner October 4, 2022 20:02
.github/workflows/actionlint.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
@krysal
Copy link
Member

krysal commented Oct 6, 2022

Thanks for your contribution, @alrz1999. These changes are already applied in #972.

@krysal krysal closed this Oct 6, 2022
@alrz1999
Copy link
Contributor Author

alrz1999 commented Oct 6, 2022

Thanks for your contribution, @alrz1999. These changes are already applied in #972.

You're welcome. Also, I think following workflows require concurrency settings:

@krysal
Copy link
Member

krysal commented Oct 6, 2022

@alrz1999 Oops! You're right, my bad! I only looked at the actionlint.yml file, reopening it to let you rebase and finish this 😄

@krysal krysal reopened this Oct 6, 2022
@alrz1999 alrz1999 requested review from sarayourfriend and removed request for dhruvkb October 11, 2022 07:30
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. These look great and make sense to me. I appreciate the care you've taken to make sure each group makes sense for the context 🙏

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@krysal krysal merged commit 87847eb into WordPress:main Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants