Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update of the old CC BASE_URL of media reports #966

Merged
merged 4 commits into from
Oct 5, 2022

Conversation

swapnalshahil
Copy link
Contributor

@swapnalshahil swapnalshahil commented Oct 4, 2022

Fixes

Fixes #965 by @krysal

Description

Currently, the media reports appear in the Django Admin with a URL from Creative Commons, meaning that when you click on the link it will count as a referrer from the old CC Search site, which is not true. The BASE_URL should be https://wordpress.org/openverse/.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@swapnalshahil swapnalshahil requested a review from a team as a code owner October 4, 2022 13:43
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Oct 4, 2022
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 4, 2022
@zackkrida
Copy link
Member

Hi @swapnalshahil this looks excellent! Do you think you could also implement this suggestion from @krysal's issue description?

preferably we can centralize this constant in the settings.py file for the example responses as well.

We are working on changing Openverse's domain again in the future, so having this constant centralized in a settings file would make that easier in the future.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close! Only needs to use the now centralized variable. I left the exact suggestions in the code comments.

api/catalog/settings.py Outdated Show resolved Hide resolved
api/catalog/api/models/media.py Outdated Show resolved Hide resolved
@swapnalshahil swapnalshahil requested review from krysal and removed request for obulat and stacimc October 5, 2022 16:56
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swapnalshahil, and congrats on your first contribution to Openverse! 🎉

@krysal krysal merged commit f431b1b into WordPress:main Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the old CC BASE_URL of media reports
6 participants