This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #927 by @AetherUnbound
Addresses #925 by @chrisbartoloburlo
Description
This PR fixes the issue of
AssertionError
s being raised instead of a 404 response. The docs forget_api_exception
say that they are supposed to be used with theraise
keyword as what it returns are exceptions, not responses.This PR also handles trailing slashes in URLs. We have been consistently pushes for uniformly using trailing URLs everywhere so our own endpoints should reasonably support them. This is a backwards compatible change.
This PR also adds tests for these changes so that we never regress on them in the future.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin