Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

updates to new redoc link #901

Closed

Conversation

ramadanomar
Copy link
Contributor

Fixes

#900 by @ramadanomar . If i find any more dead/expired links , i'll try to update them here to prevent from filling out the pr/issue list with small changes like this.

@ramadanomar ramadanomar requested a review from a team as a code owner August 27, 2022 10:08
@ramadanomar ramadanomar requested review from krysal and stacimc August 27, 2022 10:08
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Aug 27, 2022
@ramadanomar ramadanomar mentioned this pull request Aug 28, 2022
1 task
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually points to an image which is referenced on the produced documentation page here: https://wordpress.github.io/openverse-api/guides/quickstart.html#steps

The image itself can be found here: https://github.com/WordPress/openverse-api/blob/main/api/docs/_static/api_redoc.png

While reviewing this though, I did notice that the API's README references the frontend dev docs rather than the API!

- [Developer docs](https://wordpress.github.io/openverse-frontend/)

This PR could adjust that link instead 😄

@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 📄 aspect: text Concerns the textual material in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 30, 2022
@krysal krysal marked this pull request as draft September 8, 2022 18:49
@WordPress WordPress deleted a comment from openverse-bot Sep 13, 2022
@krysal
Copy link
Member

krysal commented Sep 13, 2022

@ramadanomar Could you keep working on this PR? The linked issue is fixed but it would be nice to correct the image that @AetherUnbound mentioned. It's okay if you are not available at the moment, we understand, just (preferably) let us know :)

@krysal krysal closed this Sep 23, 2022
@AetherUnbound AetherUnbound mentioned this pull request Sep 23, 2022
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants