Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add unit tests for _paginate_with_dead_link_mask #891

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

sarayourfriend
Copy link
Contributor

Fixes

Fixes #871 by @AetherUnbound

Description

Wow, what a monster of a function. There are a lot of branches, each with their own possible edge cases. The third branch is by far the most complex and writing cases for it is likewise complex. I've had a hard time wrapping my head around possible edge cases, particularly because the third branch handles the edge cases so well, so each sub-branch is already exercising one possible edge case anyway. I think they're all sufficiently covered, but let me know if you notice any holes.

Testing Instructions

Read the tests. They should pass CI and should make sense. Review the additional documentation I've added.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend requested a review from a team as a code owner August 19, 2022 16:14
@openverse-bot openverse-bot added 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository 🟨 priority: medium Not blocking but should be addressed soon labels Aug 19, 2022
@github-actions
Copy link

github-actions bot commented Aug 19, 2022

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/891

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing such comprehensive documentation for this test! I could not think of any edge cases to add.

Comment on lines +40 to +52
def _unmasked_query_end(page_size, page):
"""
Used to retrieve the upper index of results to retrieve
from Elasticsearch under the following conditions:
1. There is no query mask
2. The lower index is beyond the scope of the existing query mask
3. The lower index is within the scope of the existing query mask
but the upper index exceeds it

In all these cases, the query mask is not used to calculate the upper index.
"""
return ceil(page_size * page / (1 - DEAD_LINK_RATIO))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent documentation, lgtm.

@sarayourfriend sarayourfriend merged commit 5fae4eb into main Aug 23, 2022
@sarayourfriend sarayourfriend deleted the add/paginate-with-dead-links-unit-tests branch August 23, 2022 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests for _paginate_with_dead_link_mask
4 participants