Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Ignore DisallowedHosts logs from Sentry #842

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

sarayourfriend
Copy link
Contributor

Description

Ignores the logging mentioned in the comment as it's completely un-actionable.

Testing Instructions

Run the API locally and verify that you can make requests without issue.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Aug 2, 2022
@sarayourfriend sarayourfriend requested a review from a team as a code owner August 2, 2022 12:29
@sarayourfriend
Copy link
Contributor Author

To whichever Openverse maintainer with Sentry access, please document the resolution when this is committed to main on the Sentry issue so that we don't keep getting alerts for this: https://sentry.io/share/issue/9af3cdf8ef74420aa7bbb6697760a82c/

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/842

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we disallow that host in particular? openverse-api-alb-605315325.us-east-1.elb.amazonaws.com
I haven't seen another spammy address but if we silence the whole exception, it could be hard to debug if there are infrastructure changes in the future.

api/catalog/settings.py Outdated Show resolved Hide resolved
@sarayourfriend
Copy link
Contributor Author

Can we disallow that host in particular? openverse-api-alb-605315325.us-east-1.elb.amazonaws.com

All hosts other than the allowed hosts are already disallowed. And the ALB DNS name is liable to change whenever the ALB is redeployed anyway.

This is only excluding this from Sentry (it is truly unactionable from a Sentry perspective) so we will still see this error in the logs. If we're trying to debug infrastructure changes we'll still be able to see this information in the logs, it just won't keep getting sent to Sentry where it's effectively useless information outside of the edge case of when we're configuring a new deployment and therefore actively watching the logs and debugging this kind of thing.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! Forgot this is only to silence it from Sentry, we still have Django logs, so this is great. Thanks!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea

@sarayourfriend sarayourfriend merged commit 35fa6eb into main Aug 2, 2022
@sarayourfriend sarayourfriend deleted the add/sentry-ignores branch August 2, 2022 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants