-
Notifications
You must be signed in to change notification settings - Fork 50
Ignore DisallowedHosts logs from Sentry #842
Conversation
To whichever Openverse maintainer with Sentry access, please document the resolution when this is committed to main on the Sentry issue so that we don't keep getting alerts for this: https://sentry.io/share/issue/9af3cdf8ef74420aa7bbb6697760a82c/ |
API Developer Docs Preview: Ready https://wordpress.github.io/openverse-api/_preview/842 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we disallow that host in particular? openverse-api-alb-605315325.us-east-1.elb.amazonaws.com
I haven't seen another spammy address but if we silence the whole exception, it could be hard to debug if there are infrastructure changes in the future.
All hosts other than the allowed hosts are already disallowed. And the ALB DNS name is liable to change whenever the ALB is redeployed anyway. This is only excluding this from Sentry (it is truly unactionable from a Sentry perspective) so we will still see this error in the logs. If we're trying to debug infrastructure changes we'll still be able to see this information in the logs, it just won't keep getting sent to Sentry where it's effectively useless information outside of the edge case of when we're configuring a new deployment and therefore actively watching the logs and debugging this kind of thing. |
52f952d
to
0330180
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! Forgot this is only to silence it from Sentry, we still have Django logs, so this is great. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea
Description
Ignores the logging mentioned in the comment as it's completely un-actionable.
Testing Instructions
Run the API locally and verify that you can make requests without issue.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin