-
Notifications
You must be signed in to change notification settings - Fork 50
Removed the "cc-catalog" references from the system-architecure diagram. #771
Conversation
Where should I put the XML file and the link to the draw.io project? |
@raghuvar-arora-au2 how about moving all of this into a subdirectory of the
and then the link to draw.io could go in that readme file? if you do it this way, make sure to update path to the image in the repo README file. The diagram looks excellent! Thanks for this. |
Made the changes, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @raghuvar-arora-au2! It looks like you'll need to run just lint
at the root of the repository and commit the changes to the markdown file, but otherwise this is great to see 🙂
I left a couple things that would be nice to update while we're making this change as well.
Additionally, I don't think the shares.cc
service is running anymore, but maybe @zackkrida could confirm that. We might want to remove that block as well.
Thanks again for the contribution!!
<mxCell id="JVIGxF9oKAkimninJbSp-58" value="-Search queries<br>-Tag Stats&nbsp; &nbsp; &nbsp; &nbsp;&nbsp;" style="text;html=1;align=left;verticalAlign=middle;resizable=0;points=[];autosize=1;strokeColor=none;fillColor=none;" vertex="1" parent="1"> | ||
<mxGeometry x="770" y="350" width="110" height="40" as="geometry" /> | ||
</mxCell> | ||
<mxCell id="JVIGxF9oKAkimninJbSp-59" value="-Site cache&nbsp; &nbsp; &nbsp; &nbsp;&nbsp;<br>-Traffic stats&nbsp; &nbsp; &nbsp;&nbsp;<br>-Dead link cache" style="text;html=1;align=left;verticalAlign=middle;resizable=0;points=[];autosize=1;strokeColor=none;fillColor=none;" vertex="1" parent="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer hold traffic stats anywhere as far as I am aware, so I think we can remove that bit.
<mxCell id="JVIGxF9oKAkimninJbSp-59" value="-Site cache&nbsp; &nbsp; &nbsp; &nbsp;&nbsp;<br>-Traffic stats&nbsp; &nbsp; &nbsp;&nbsp;<br>-Dead link cache" style="text;html=1;align=left;verticalAlign=middle;resizable=0;points=[];autosize=1;strokeColor=none;fillColor=none;" vertex="1" parent="1"> | |
<mxCell id="JVIGxF9oKAkimninJbSp-59" value="-Site cache&nbsp; &nbsp; &nbsp; &nbsp;&nbsp;<br>-Dead link cache" style="text;html=1;align=left;verticalAlign=middle;resizable=0;points=[];autosize=1;strokeColor=none;fillColor=none;" vertex="1" parent="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for amazing work, @raghuvar-arora-au2 !
There are a couple of things that we don't have anymore, could you please remove them. I've scratched them out in the screenshot below:
This is looking great! 🎉 Can we update the text "Ingest" here to say "Data refresh"? Context in comment. (I do think it's correct to keep the phrase "Ingestion server", since the server is currently named that). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new diagram is very nice! Thanks @raghuvar-arora-au2.
I'm not sure if we should be including the frontend in the diagram that's in the API repo, but it's not wrong so not a problem.
One technical change in the "API Database" ↔ "API Server Group" link is that we no longer have link shortening data and lists. Those tables exist but that functionality has been deactivated.
Also a couple of grammatical improvements:
- "Django-api" → "Django API"
- "frontend" → "Frontend"
<mxCell id="JVIGxF9oKAkimninJbSp-10" value="API Server Group<br><br><br><br><br>" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#dae8fc;strokeColor=#6c8ebf;" parent="1" vertex="1"> | ||
<mxGeometry x="435" y="430" width="300" height="130" as="geometry" /> | ||
</mxCell> | ||
<mxCell id="JVIGxF9oKAkimninJbSp-12" value="Django-api" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#ffe6cc;strokeColor=#d79b00;" parent="1" vertex="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<mxCell id="JVIGxF9oKAkimninJbSp-12" value="Django-api" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#ffe6cc;strokeColor=#d79b00;" parent="1" vertex="1"> | |
<mxCell id="JVIGxF9oKAkimninJbSp-12" value="Django API" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#ffe6cc;strokeColor=#d79b00;" parent="1" vertex="1"> |
<mxCell id="JVIGxF9oKAkimninJbSp-12" value="Django-api" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#ffe6cc;strokeColor=#d79b00;" parent="1" vertex="1"> | ||
<mxGeometry x="455" y="480" width="80" height="40" as="geometry" /> | ||
</mxCell> | ||
<mxCell id="JVIGxF9oKAkimninJbSp-13" value="Django-api" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#ffe6cc;strokeColor=#d79b00;" parent="1" vertex="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<mxCell id="JVIGxF9oKAkimninJbSp-13" value="Django-api" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#ffe6cc;strokeColor=#d79b00;" parent="1" vertex="1"> | |
<mxCell id="JVIGxF9oKAkimninJbSp-13" value="Django API" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#ffe6cc;strokeColor=#d79b00;" parent="1" vertex="1"> |
<mxCell id="JVIGxF9oKAkimninJbSp-13" value="Django-api" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#ffe6cc;strokeColor=#d79b00;" parent="1" vertex="1"> | ||
<mxGeometry x="545" y="480" width="80" height="40" as="geometry" /> | ||
</mxCell> | ||
<mxCell id="JVIGxF9oKAkimninJbSp-14" value="Django-api" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#ffe6cc;strokeColor=#d79b00;" parent="1" vertex="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<mxCell id="JVIGxF9oKAkimninJbSp-14" value="Django-api" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#ffe6cc;strokeColor=#d79b00;" parent="1" vertex="1"> | |
<mxCell id="JVIGxF9oKAkimninJbSp-14" value="Django API" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#ffe6cc;strokeColor=#d79b00;" parent="1" vertex="1"> |
<mxCell id="JVIGxF9oKAkimninJbSp-15" value="Load Balancer" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#dae8fc;strokeColor=#6c8ebf;" parent="1" vertex="1"> | ||
<mxGeometry x="525" y="590" width="120" height="40" as="geometry" /> | ||
</mxCell> | ||
<mxCell id="JVIGxF9oKAkimninJbSp-16" value="frontend" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#f8cecc;strokeColor=#b85450;" parent="1" vertex="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<mxCell id="JVIGxF9oKAkimninJbSp-16" value="frontend" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#f8cecc;strokeColor=#b85450;" parent="1" vertex="1"> | |
<mxCell id="JVIGxF9oKAkimninJbSp-16" value="Frontend" style="rounded=0;whiteSpace=wrap;html=1;strokeWidth=1;fillColor=#f8cecc;strokeColor=#b85450;" parent="1" vertex="1"> |
<mxCell id="JVIGxF9oKAkimninJbSp-64" value="Other infrastructure" style="shape=partialRectangle;html=1;whiteSpace=wrap;connectable=0;fillColor=#dae8fc;top=0;left=0;bottom=0;right=0;overflow=hidden;pointerEvents=1;align=left;spacingLeft=10;strokeWidth=1;strokeColor=#6c8ebf;" parent="JVIGxF9oKAkimninJbSp-62" vertex="1"> | ||
<mxGeometry y="30" width="180" height="30" as="geometry" /> | ||
</mxCell> | ||
<mxCell id="JVIGxF9oKAkimninJbSp-65" value="External dependancy" style="shape=partialRectangle;html=1;whiteSpace=wrap;connectable=0;fillColor=#f8cecc;top=0;left=0;bottom=0;right=0;overflow=hidden;pointerEvents=1;align=left;spacingLeft=10;strokeWidth=1;strokeColor=#b85450;" parent="JVIGxF9oKAkimninJbSp-62" vertex="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<mxCell id="JVIGxF9oKAkimninJbSp-65" value="External dependancy" style="shape=partialRectangle;html=1;whiteSpace=wrap;connectable=0;fillColor=#f8cecc;top=0;left=0;bottom=0;right=0;overflow=hidden;pointerEvents=1;align=left;spacingLeft=10;strokeWidth=1;strokeColor=#b85450;" parent="JVIGxF9oKAkimninJbSp-62" vertex="1"> | |
<mxCell id="JVIGxF9oKAkimninJbSp-65" value="External dependency" style="shape=partialRectangle;html=1;whiteSpace=wrap;connectable=0;fillColor=#f8cecc;top=0;left=0;bottom=0;right=0;overflow=hidden;pointerEvents=1;align=left;spacingLeft=10;strokeWidth=1;strokeColor=#b85450;" parent="JVIGxF9oKAkimninJbSp-62" vertex="1"> |
<mxCell id="JVIGxF9oKAkimninJbSp-59" value="-Site cache&nbsp; &nbsp; &nbsp; &nbsp;&nbsp;&nbsp; &nbsp; &nbsp;&nbsp;<br>-Dead link cache" style="text;html=1;align=left;verticalAlign=middle;resizable=0;points=[];autosize=1;strokeColor=none;fillColor=none;" parent="1" vertex="1"> | ||
<mxGeometry x="590" y="360" width="125" height="41" as="geometry" /> | ||
</mxCell> | ||
<mxCell id="JVIGxF9oKAkimninJbSp-60" value="-Detail views<br>-Lists&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;<br>-Content provider data<br><div style=""><span style="background-color: initial;">-Link shortening data</span></div>" style="text;html=1;align=left;verticalAlign=middle;resizable=0;points=[];autosize=1;strokeColor=none;fillColor=none;" parent="1" vertex="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<mxCell id="JVIGxF9oKAkimninJbSp-60" value="-Detail views<br>-Lists&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;<br>-Content provider data<br><div style=""><span style="background-color: initial;">-Link shortening data</span></div>" style="text;html=1;align=left;verticalAlign=middle;resizable=0;points=[];autosize=1;strokeColor=none;fillColor=none;" parent="1" vertex="1"> | |
<mxCell id="JVIGxF9oKAkimninJbSp-60" value="-Detail views<br>-Lists&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;<br>-Content provider data<br><div style=""><span style="background-color: initial;"></span></div>" style="text;html=1;align=left;verticalAlign=middle;resizable=0;points=[];autosize=1;strokeColor=none;fillColor=none;" parent="1" vertex="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this suggestion will work for PNG generation, but we should remove the Link shortening data
here, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @raghuvar-arora-au2 ! The diagram looks great 🎉
Just dropping in to say thanks so much for this contribution @raghuvar-arora-au2! This is excellent 🥳 |
Fixes
Fixes #758 by @sarayourfriend
Description
Recreated the diagram in draw.io, and removed the cc-catolog references.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin