-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to approve this now; regardless of any potential concerns, it's certainly more accurate than the current, live document, which seems like a win.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nit-picky things. Agreed with Zack though, it doesn't seem like we need to necessarily wait to get it live considering the existing one is wrong... but IANAL so 🧂 😬
In connection with your use of the Openverse API: | ||
|
||
- You must adhere to all rate limits, registration requirements, and comply with all requirements in the Openverse API documentation; | ||
- You must not scrape the content in the Openverse Catalog; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You must not scrape the content in the Openverse Catalog
I'm also not sure what this line means; is it trying to discourage making a bulk copy of all the data supplied by the API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am honestly not sure. The "catalog" itself isn't even public. I'm happy to delete this line 🤷🏼♀️
Co-authored-by: sarayourfriend <[email protected]> Co-authored-by: Zack Krida <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I feel safe merging this like Zack suggested, nothing seems too risky and the existing one is bogus. We can update it once we get feedback from WPF folks.
LICENSE
Outdated
@@ -1,6 +1,6 @@ | |||
MIT License | |||
|
|||
Copyright (c) 2018 Creative Commons | |||
Copyright (c) 2022 WordPress Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think actually this should be "the contributors" to match Gutenberg and core's license text:
https://github.com/WordPress/gutenberg/blob/trunk/LICENSE.md
https://github.com/WordPress/wordpress-develop/blob/trunk/src/license.txt#L3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible, thank you!
Co-authored-by: sarayourfriend <[email protected]>
Description
Follow up from #662
This PR updates the Terms of Service document for the Openverse API. The current version of the document is hosted here: https://api.openverse.engineering/terms_of_service.html and can be found in code here: https://github.com/WordPress/openverse-api/blob/v2.4.3/api/terms_of_service.html
The new ToS will be located along with the rest of our API dev documentation here: https://wordpress.github.io/openverse-api/terms_of_service.html (URL won't work until this is merged).
This PR also includes changes to our ToS wording. A rough difference view between the two can be found here: https://www.diffchecker.com/gc9T5FrF
Most notably, the following has changed:
Testing Instructions
just sphinx-make
just sphinx-serve
swagger.py
to betos_url = "http://0.0.0.0:3001/terms_of_service.html"
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin