Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove pipdeptree #519

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Remove pipdeptree #519

merged 3 commits into from
Feb 16, 2022

Conversation

0xwho7
Copy link
Contributor

@0xwho7 0xwho7 commented Feb 16, 2022

Fixes

Fixes #516 by @[issue author]

Description

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@0xwho7 0xwho7 requested a review from a team as a code owner February 16, 2022 15:36
@0xwho7
Copy link
Contributor Author

0xwho7 commented Feb 16, 2022

#516

@sarayourfriend sarayourfriend added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed labels Feb 16, 2022
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced dependencies 🎉 !

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @gowthamchowdary!

It looks like you might need to run just install in the top level of the repository again to fully update the Pipefile.lock.

@0xwho7
Copy link
Contributor Author

0xwho7 commented Feb 16, 2022

hope this is what you meant, @sarayourfriend !

@sarayourfriend
Copy link
Contributor

Sorry @gowthamchowdary, that looks like it added a new pipfile to the top level of the repository. If you run just install using the just command runner as described in the projects README it will traverse the three Python projects in this repository, and run pipenv install in each of them, thereby updating the lock files. Hope this helps. Let me know if you need any extra instructions.

@0xwho7
Copy link
Contributor Author

0xwho7 commented Feb 16, 2022

got it, thank you @sarayourfriend . i'm doing it as i type this, will update as soon as it's done.

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! Thanks so much! 🎉

@sarayourfriend sarayourfriend merged commit 0fa3575 into WordPress:main Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pipdeptree
3 participants