Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Run CI/CD on every pull request #507

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

AetherUnbound
Copy link
Contributor

Fixes

Fixes #443 by @dhruvkb

Description

This PR removes the main constraint for PR triggers in the CI/CD workflow so that all PRs run the docker building, testing, and integration test steps.

Testing Instructions

We could potentially open a PR onto this PR if we wanted to test that it works.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner February 6, 2022 23:06
@AetherUnbound AetherUnbound added 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Feb 6, 2022
@AetherUnbound AetherUnbound requested a review from a team February 6, 2022 23:06
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Glad it was this straight forward 🙂

For reference for anyone else, here's the documentation for the pull_request event (which confused me at first): https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

@AetherUnbound AetherUnbound mentioned this pull request Feb 6, 2022
@AetherUnbound
Copy link
Contributor Author

Looks like things are working okay! (See #508)

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarayourfriend
Copy link
Contributor

@AetherUnbound merging this as it's been approved for a while and we've confirmed it works.

@sarayourfriend sarayourfriend merged commit da80513 into main Feb 21, 2022
@sarayourfriend sarayourfriend deleted the feature/integration-tests-pr branch February 21, 2022 18:43
@AetherUnbound
Copy link
Contributor Author

AetherUnbound commented Feb 21, 2022

My goodness, thanks for doing that! Sorry I missed this, I missed that there were already 2 reviews.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run integration tests on all PRs
3 participants