Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add environment to data refresh slack alert username #477

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

AetherUnbound
Copy link
Contributor

Fixes

Fixes #473 by @AetherUnbound

Description

This is a small PR which adds the running environment to the data refresh slack alert username. This will help us distinguish which runs are occurring in production and which are in staging/other environments.

I also added tests for this module, now that I've improved the testing setup in #474!

Testing Instructions

just ing-testlocal

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner January 20, 2022 23:25
@AetherUnbound AetherUnbound requested review from zackkrida and sarayourfriend and removed request for a team January 20, 2022 23:25
@AetherUnbound AetherUnbound added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟧 priority: high Stalls work on the project or its dependents labels Jan 20, 2022
@AetherUnbound AetherUnbound requested a review from a team January 20, 2022 23:25
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the triply parameterized test!

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto to the coolness of the test!

@AetherUnbound
Copy link
Contributor Author

Love me some Cartesian products 😁

@AetherUnbound AetherUnbound added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟧 priority: high Stalls work on the project or its dependents and removed 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Jan 21, 2022
Base automatically changed from feature/dev-data-refresh-subset#472 to main January 21, 2022 20:20
@AetherUnbound AetherUnbound force-pushed the feature/dev-prod-slack-messages#473 branch from 98d4fa8 to c4422b0 Compare January 21, 2022 20:21
@AetherUnbound AetherUnbound merged commit 59f9092 into main Jan 21, 2022
@AetherUnbound AetherUnbound deleted the feature/dev-prod-slack-messages#473 branch January 21, 2022 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish between staging & prod when sending data refresh slack updates
3 participants