-
Notifications
You must be signed in to change notification settings - Fork 50
Correct docker repository for the ingestion server, update docs #458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about environment variable interpolation inside docker-compose.yml
! Very cool 👍
We were trying to come up with a solution on a different project for pinning the version in the prod compose file without having to change the text and this fit the bill perfectly! |
When running I just copied
Is the container name supposed to have |
@obulat you can also create the |
I also might have had a very old version of api locally... |
Oh just kidding, it absolutely is expecting a |
d726ad7
to
fe023ea
Compare
0e9d2df
to
90e3d2d
Compare
Co-authored-by: Dhruv Bhanushali <[email protected]>
90e3d2d
to
14376f8
Compare
Description
This PR corrects the docker repository name used in production for the ingestion server. This format changed as a part of #437. It also adds a way to easily override the desired tag using an environment variable (in this case, in the local
.env
file on production). This way we can specify which version we want to pull/run without having to update the file on every version bump.Lastly, I added some documentation to the DNS segment based on discussion in #346.
Testing Instructions
cd ingestion_server
docker-compose pull
(optionally setting theIMAGE_TAG
variable to a specific version tag, e.g.v2.1.1
)docker-compose up -d
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin