This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Override default RELATIVE_UPSTREAM_DB_* vars for integration tests #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #447 by @AetherUnbound
Description
This PR resolves an issue wherein the integration tests were failing after running
just env
. It turns out that the decouple library (which is being used to initialize theRELATIVE_UPSTREAM_DB_*
variables) was picking up the variables in the.env
file created under theingestion_server
directory. SinceRELATIVE_UPSTREAM_DB_*
is explicitly defined in theenv.template
file, it was overriding the default, which would normally fall back to theUPSTREAM_DB_*
values. Since the services are named differently for integration tests, this would then cause the tests to fail.There are a few ways to correct this, but the easiest seemed to be just to explicitly define them in the environment file for the service since decouple gives precedence to environment variables over those loaded from a
.env
file.Testing Instructions
just env
just ing-testlocal
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin