Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add hook to clean up YAML files #435

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Add hook to clean up YAML files #435

merged 1 commit into from
Dec 28, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Dec 27, 2021

Fixes

Fixes #410 by @dhruvkb

Description

This PR adds a new pre-commit hook to format YAML files.

Testing Instructions

Formatting changes are adequately tested by passing lint check.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Dec 27, 2021
dhruvkb added a commit that referenced this pull request Dec 27, 2021
@dhruvkb dhruvkb marked this pull request as ready for review December 27, 2021 18:35
@dhruvkb dhruvkb requested a review from a team as a code owner December 27, 2021 18:35
@dhruvkb dhruvkb requested review from rbadillap and obulat December 27, 2021 18:35
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we want to add this to the main Openverse repo?

@dhruvkb dhruvkb merged commit 0f6aed8 into main Dec 28, 2021
@dhruvkb dhruvkb deleted the lint_yml branch December 28, 2021 05:36
@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 28, 2021

@AetherUnbound WordPress/openverse#131

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint YAML files
4 participants