This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olga Bulat [email protected]
Fixes
Fixes #393 by @obulat
Description
This PR sets the page_size for
/related/
endpoint to a constant of 10. This is not elegant, the constant should probably be set elsewhere, but I'm not familiar enough with the API codebase to find the correct place.Testing Instructions
Run the api (just up/just init), and then go to
http://localhost:8000/v1/images/41d51a9c-cdf5-4ca6-acfc-ebd63f807ecf/related/
You should see that although the result count is over 1200, the page_size is set to 10, and there is no error.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin