Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix page_size setting for related media #394

Merged
merged 2 commits into from
Dec 11, 2021
Merged

Fix page_size setting for related media #394

merged 2 commits into from
Dec 11, 2021

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Dec 11, 2021

Signed-off-by: Olga Bulat [email protected]

Fixes

Fixes #393 by @obulat

Description

This PR sets the page_size for /related/ endpoint to a constant of 10. This is not elegant, the constant should probably be set elsewhere, but I'm not familiar enough with the API codebase to find the correct place.

Testing Instructions

Run the api (just up/just init), and then go to http://localhost:8000/v1/images/41d51a9c-cdf5-4ca6-acfc-ebd63f807ecf/related/
You should see that although the result count is over 1200, the page_size is set to 10, and there is no error.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Dec 11, 2021
@obulat obulat requested a review from a team as a code owner December 11, 2021 19:02
@obulat obulat self-assigned this Dec 11, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment suggestion, LGTM!

@zackkrida zackkrida merged commit c67f7bd into main Dec 11, 2021
@zackkrida zackkrida deleted the fix_related branch December 11, 2021 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

page_size for /related/ endpoint is set incorrectly and causes 400 error
3 participants