Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Include deleted & mature existence checks when updating indices #365

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

AetherUnbound
Copy link
Contributor

Fixes

Fixes #361 by @AetherUnbound

Description

This PR adds the deleted and mature existence columns for the query which pulls records in order to update elasticsearch. It also adds tests which run the UPDATE_INDEX action for both images & audio.

Testing Instructions

just ing-testlocal

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound added 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Nov 20, 2021
@AetherUnbound AetherUnbound requested review from a team, zackkrida and krysal and removed request for a team November 20, 2021 01:10
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch and elegant fix! Also, appreciate the additional tests.

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice tests; great fix.

@AetherUnbound AetherUnbound force-pushed the bugfix/ingestion-index-update branch from e7f2897 to 16f4dd6 Compare November 30, 2021 00:22
@AetherUnbound AetherUnbound requested a review from a team as a code owner November 30, 2021 00:22
@AetherUnbound AetherUnbound changed the base branch from bugfix/relative-upstream-db to main November 30, 2021 00:22
@AetherUnbound AetherUnbound merged commit 8bf0ce5 into main Nov 30, 2021
@AetherUnbound AetherUnbound deleted the bugfix/ingestion-index-update branch November 30, 2021 00:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index update fails on missing deleted columns
3 participants