Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add integration tests, including those for audio, to the ingestion-server #318

Merged
merged 6 commits into from
Oct 28, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Oct 21, 2021

Fixes

Fixes #265 by @zackkrida

Description

This PR adds testing for the ingestion server and incorporates this testing in CI. It also adds the needed data files (such as mock data and schemas for the DBs) and scripts used to generate them.

The ingestion server tests spawn containers in their own Docker Compose bubble, wait for them to come up, send API calls to the mock server, listen for callbacks using a Bottle server and finally validate the presence of data in the downstream DB.

Testing Instructions

The test are a part of the CI. Nothing is needed to be done separately.

If you still want to run the tests locally for the macOS environment, install the Pipenv dependencies in ingestion_server/ using just _ing-install and run just ing-testlocal.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🌟 goal: addition Addition of new feature 🤖 aspect: dx Concerns developers' experience with the codebase labels Oct 21, 2021
Base automatically changed from just_in_ci to main October 22, 2021 17:54
@dhruvkb dhruvkb force-pushed the is_tests branch 6 times, most recently from 442ea90 to d52af90 Compare October 25, 2021 08:22
@dhruvkb dhruvkb changed the title Add a test runner script à la the API codebase Add integration tests to the ingestion-server including audio Oct 25, 2021
@dhruvkb dhruvkb force-pushed the is_tests branch 7 times, most recently from 1536cb7 to 25af21a Compare October 25, 2021 17:53
@dhruvkb dhruvkb marked this pull request as ready for review October 26, 2021 04:23
@dhruvkb dhruvkb requested a review from a team as a code owner October 26, 2021 04:23
@dhruvkb dhruvkb requested review from rbadillap and krysal October 26, 2021 04:23
@zackkrida
Copy link
Member

@dhruvkb could you please add the 'testing instructions' block to this PR? Any additional description you think would be useful is appreciated too.

@dhruvkb
Copy link
Member Author

dhruvkb commented Oct 26, 2021

@zackkrida updated testing instructions and description. Imo, the passing CI is enough validation (at least for Linux).

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much work! Now we can be more confident about making any changes in the ingestion-server.

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

ingestion_server/test/update_mocks.sh Show resolved Hide resolved
@zackkrida zackkrida self-requested a review October 28, 2021 16:35
@dhruvkb dhruvkb changed the title Add integration tests to the ingestion-server including audio Add integration tests, including those for audio, to the ingestion-server Oct 28, 2021
@dhruvkb dhruvkb merged commit 449221d into main Oct 28, 2021
@dhruvkb dhruvkb deleted the is_tests branch October 28, 2021 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add audio to the ingestion server tests
4 participants