This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Add integration tests, including those for audio, to the ingestion-server #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkb
added
🌟 goal: addition
Addition of new feature
🤖 aspect: dx
Concerns developers' experience with the codebase
labels
Oct 21, 2021
zackkrida
reviewed
Oct 21, 2021
dhruvkb
force-pushed
the
is_tests
branch
6 times, most recently
from
October 25, 2021 08:22
442ea90
to
d52af90
Compare
dhruvkb
changed the title
Add a test runner script à la the API codebase
Add integration tests to the ingestion-server including audio
Oct 25, 2021
dhruvkb
force-pushed
the
is_tests
branch
7 times, most recently
from
October 25, 2021 17:53
1536cb7
to
25af21a
Compare
@dhruvkb could you please add the 'testing instructions' block to this PR? Any additional description you think would be useful is appreciated too. |
@zackkrida updated testing instructions and description. Imo, the passing CI is enough validation (at least for Linux). |
obulat
reviewed
Oct 26, 2021
obulat
reviewed
Oct 26, 2021
obulat
reviewed
Oct 26, 2021
obulat
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much work! Now we can be more confident about making any changes in the ingestion-server.
AetherUnbound
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
dhruvkb
changed the title
Add integration tests to the ingestion-server including audio
Add integration tests, including those for audio, to the ingestion-server
Oct 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🤖 aspect: dx
Concerns developers' experience with the codebase
🌟 goal: addition
Addition of new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #265 by @zackkrida
Description
This PR adds testing for the ingestion server and incorporates this testing in CI. It also adds the needed data files (such as mock data and schemas for the DBs) and scripts used to generate them.
The ingestion server tests spawn containers in their own Docker Compose bubble, wait for them to come up, send API calls to the mock server, listen for callbacks using a Bottle server and finally validate the presence of data in the downstream DB.
Testing Instructions
The test are a part of the CI. Nothing is needed to be done separately.
If you still want to run the tests locally for the macOS environment, install the Pipenv dependencies in
ingestion_server/
usingjust _ing-install
and runjust ing-testlocal
.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin