Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove redundant steps and use just recipes in CI #316

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Remove redundant steps and use just recipes in CI #316

merged 2 commits into from
Oct 22, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Oct 20, 2021

Fixes

Fixes #239 by @dhruvkb
Fixes #236 by @dhruvkb

Description

This PR changes the CI workflow to use just, which reduces steps and commands in favour of a more readable CI file.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added ✨ goal: improvement Improvement to an existing user-facing feature 🤖 aspect: dx Concerns developers' experience with the codebase labels Oct 20, 2021
@dhruvkb dhruvkb force-pushed the just_in_ci branch 2 times, most recently from ab48989 to 6c49533 Compare October 20, 2021 22:49
@dhruvkb dhruvkb marked this pull request as ready for review October 20, 2021 22:55
@dhruvkb dhruvkb requested a review from a team as a code owner October 20, 2021 22:55
.github/workflows/integration_tests.yml Outdated Show resolved Hide resolved
.github/workflows/integration_tests.yml Outdated Show resolved Hide resolved
ingestion_server/.dockerignore Show resolved Hide resolved
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some questions but no blockers 🚀

.github/workflows/integration_tests.yml Show resolved Hide resolved
.github/workflows/integration_tests.yml Show resolved Hide resolved
.github/workflows/integration_tests.yml Show resolved Hide resolved
.github/workflows/integration_tests.yml Outdated Show resolved Hide resolved
@dhruvkb dhruvkb requested a review from AetherUnbound October 22, 2021 09:46
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dhruvkb dhruvkb changed the title Remove redundant steps and use just recipes Remove redundant steps and use just recipes in CI Oct 22, 2021
@dhruvkb dhruvkb merged commit ebad30c into main Oct 22, 2021
@dhruvkb dhruvkb deleted the just_in_ci branch October 22, 2021 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Use just commands in the CI workflow Improve speed of lint check
3 participants