This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Remove redundant steps and use just
recipes in CI
#316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkb
added
✨ goal: improvement
Improvement to an existing user-facing feature
🤖 aspect: dx
Concerns developers' experience with the codebase
labels
Oct 20, 2021
dhruvkb
force-pushed
the
just_in_ci
branch
2 times, most recently
from
October 20, 2021 22:49
ab48989
to
6c49533
Compare
sarayourfriend
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some questions but no blockers 🚀
AetherUnbound
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
dhruvkb
changed the title
Remove redundant steps and use
Remove redundant steps and use Oct 22, 2021
just
recipesjust
recipes in CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🤖 aspect: dx
Concerns developers' experience with the codebase
✨ goal: improvement
Improvement to an existing user-facing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #239 by @dhruvkb
Fixes #236 by @dhruvkb
Description
This PR changes the CI workflow to use
just
, which reduces steps and commands in favour of a more readable CI file.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin