-
Notifications
You must be signed in to change notification settings - Fork 50
Add pre-commit, format all files, and add justfile #224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one thought for re-ordering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so awesome! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed 'just' when coming from the catalog repository :) Thank you for improving DX!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarayourfriend this PR does not update the README.md
file in the root? #201 had that updated to match the just
commands.
@dhruvkb whoops, I missed that when moving things over to this branch, I'll update the README now. Thanks for catching that! |
such excellent work @sarayourfriend 🎉 can't wait to use these commands. thank you |
Fixes
Fixes #193 by @sarayourfriend
Fixes #187 by @sarayourfriend
Description
Adds
pre-commit
using the same configuration as theopenverse-catalog
with some modifications to ignore rules in certain files that were problematic.Also adds a
justfile
to make docker stuff easier.Technical details
I had to add some
noqa
comments for long strings (I wish flake8 would ignore strings...)I also added
.flake8
that mirrors the pre-commit configuration for flake8 so that editor integration will workTests
Checkout the branch and run
just install
thenjust lint
and ensure that there are no errors reported.Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin