Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Refactor and clean up URLs and endpoints #169

Merged
merged 19 commits into from
Aug 23, 2021
Merged

Refactor and clean up URLs and endpoints #169

merged 19 commits into from
Aug 23, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Aug 11, 2021

Dependencies

Please merge #160 before this.

Description

This is a refactoring PR that cleans up, reorganises and in general improves the code quality of the endpoints. These refactors are made possible thanks to the confidence of the more comprehensive integration tests.

Technical details

The PR makes the following improvements:

  • Cleans up the URL config
    • Breaks it into more digestible chunks
    • Organises related endpoints together
    • Deprecates old endpoints, with backwards-compatible permanent redirects
  • Disables the caching for Swagger documentation in dev (no need to repeatedly clean cache to see changes now!)
  • Adheres to Django conventions about settings, path/re_path and include

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb changed the title Move Swagger documentation from URLconf to the endpoint Refactor and clean up URLs and endpoints Aug 11, 2021
@dhruvkb dhruvkb marked this pull request as ready for review August 11, 2021 08:52
@dhruvkb dhruvkb requested a review from a team as a code owner August 11, 2021 08:52
@dhruvkb dhruvkb requested review from zackkrida and obulat and removed request for a team August 11, 2021 08:52
@dhruvkb dhruvkb added ✨ goal: improvement Improvement to an existing user-facing feature 🤖 aspect: dx Concerns developers' experience with the codebase labels Aug 11, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You almost removed as much code as was added 😄 this looks good to me! appreciate the new test for deprecated endpoints.

@dhruvkb
Copy link
Member Author

dhruvkb commented Aug 13, 2021

@zackkrida by cleaning up I meant breaking up and reorganising big files into smaller modules.

@zackkrida
Copy link
Member

Yes, I just noticed the diff—this is absolutely much cleaner regardless of LOC

Base automatically changed from audio_tests to main August 13, 2021 23:42
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes. Nice to see code cleaned up :)

openverse-api/catalog/api/utils/status_code_view.py Outdated Show resolved Hide resolved
openverse-api/catalog/urls/__init__.py Show resolved Hide resolved
@dhruvkb dhruvkb merged commit 1a8f5bc into main Aug 23, 2021
@dhruvkb dhruvkb deleted the clean_endpoints branch August 23, 2021 10:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants