This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Refactor and clean up URLs and endpoints #169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkb
changed the title
Move Swagger documentation from URLconf to the endpoint
Refactor and clean up URLs and endpoints
Aug 11, 2021
dhruvkb
requested review from
zackkrida and
obulat
and removed request for
a team
August 11, 2021 08:52
dhruvkb
added
✨ goal: improvement
Improvement to an existing user-facing feature
🤖 aspect: dx
Concerns developers' experience with the codebase
labels
Aug 11, 2021
zackkrida
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You almost removed as much code as was added 😄 this looks good to me! appreciate the new test for deprecated endpoints.
@zackkrida by cleaning up I meant breaking up and reorganising big files into smaller modules. |
Yes, I just noticed the diff—this is absolutely much cleaner regardless of LOC |
obulat
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes. Nice to see code cleaned up :)
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🤖 aspect: dx
Concerns developers' experience with the codebase
✨ goal: improvement
Improvement to an existing user-facing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
Please merge #160 before this.
Description
This is a refactoring PR that cleans up, reorganises and in general improves the code quality of the endpoints. These refactors are made possible thanks to the confidence of the more comprehensive integration tests.
Technical details
The PR makes the following improvements:
settings
,path
/re_path
andinclude
Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin