Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update field names for set to avoid shadowing the built-in name #133

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Jul 7, 2021

This PR updates the field names for the AudioSet foreign key in Audio to avoid shadowing the built-in name set from Python collections.

dhruvkb added 2 commits July 7, 2021 10:33
This is not recommended practice but works as long the migrations have not run on production yet.
@dhruvkb dhruvkb requested a review from a team as a code owner July 7, 2021 05:05
@dhruvkb dhruvkb requested review from zackkrida and obulat July 7, 2021 05:05
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhruvkb dhruvkb merged commit be6df89 into main Jul 8, 2021
@dhruvkb dhruvkb deleted the set_name branch July 8, 2021 05:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants