Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Forward SSL status of upstream image URL to Photon #1080

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

sarayourfriend
Copy link
Contributor

Fixes

Some providers do not serve results over HTTP and do not redirect. The only known case of this is WP Photo Directory. We need to send an ssl=true query parameter to Photon for it to make the upstream request using HTTPS when the image URL we have is HTTPS.

Description

Send ssl=true when image_url scheme is HTTPS.

Testing Instructions

Check unit tests and confirm they correctly test the fix.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Jan 12, 2023
@sarayourfriend sarayourfriend requested a review from a team as a code owner January 12, 2023 02:16
@github-actions
Copy link

github-actions bot commented Jan 12, 2023

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/1080

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the quick fix 👍🏼

@sarayourfriend sarayourfriend merged commit d0e2e5e into main Jan 12, 2023
@sarayourfriend sarayourfriend deleted the add/send-explicitly-ssl-parameter-photon branch January 12, 2023 03:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants