This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Forward SSL status of upstream image URL to Photon #1080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Some providers do not serve results over HTTP and do not redirect. The only known case of this is WP Photo Directory. We need to send an
ssl=true
query parameter to Photon for it to make the upstream request using HTTPS when the image URL we have is HTTPS.Description
Send
ssl=true
when image_url scheme is HTTPS.Testing Instructions
Check unit tests and confirm they correctly test the fix.
Checklist
Update index.md
).main
) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin