Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add hash for livereload wheel #1059

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Add hash for livereload wheel #1059

merged 1 commit into from
Dec 29, 2022

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Dec 25, 2022

Fixes

Fixes #1058 by @AetherUnbound

Description

This PR adds the hash for the wheel distribution of livereload to resume installations using Pipenv. Refer to the issue for further details on why this broke.

Testing Instructions

  1. Check out the branch.
  2. Try building the web container: just dc build web.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner December 25, 2022 11:08
@openverse-bot openverse-bot added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP labels Dec 25, 2022
@dhruvkb dhruvkb requested review from obulat and removed request for sarayourfriend December 25, 2022 11:10
@github-actions
Copy link

github-actions bot commented Dec 25, 2022

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/1059

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great sleuthing :) I built it locally and saw no warnings.

@openverse-bot
Copy link
Collaborator

Based on the critical urgency of this PR, the following reviewers are being gently reminded to review this PR:

@AetherUnbound
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was updated 1 day(s) ago. PRs labelled with critical urgency are expected to be reviewed within 1 weekday(s)2.

@dhruvkb, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks for figuring this one out! I ran just build --no-cache without issues 😄

@AetherUnbound AetherUnbound merged commit 7f88fce into main Dec 29, 2022
@AetherUnbound AetherUnbound deleted the add_wheels_hash branch December 29, 2022 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current package set fails to install
4 participants