Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update default accuracy to None to support null JSON values #1033

Merged
merged 7 commits into from
Dec 14, 2022
Merged

Update default accuracy to None to support null JSON values #1033

merged 7 commits into from
Dec 14, 2022

Conversation

sahil-R
Copy link
Contributor

@sahil-R sahil-R commented Dec 6, 2022

Fixes

Fixes #674 by @dhruvkb

Description

The issue stated that the serializers were not allowing null values to be passed on in the response JSON which is returned by the API,The code was running fine when tested however the accuracy were not accompanied with the tags which were added to the response,added the fix with default accuracy as None and edited the test cases for the same.

Testing Instructions

just do any API request and the output runs fine as usual with null values returned as well.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sahil-R sahil-R requested a review from a team as a code owner December 6, 2022 18:12
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Dec 6, 2022
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the root Pipfile and Pipfile.lock. Both the api/ and ingestion_server/ have their Python environments in their directories.

api/catalog/api/serializers/media_serializers.py Outdated Show resolved Hide resolved
@sahil-R sahil-R requested review from dhruvkb and removed request for sarayourfriend December 11, 2022 11:29
@sahil-R sahil-R changed the title Improvement674 Improvement674 Update default accuracy to None to support null JSON values Dec 11, 2022
@dhruvkb
Copy link
Member

dhruvkb commented Dec 11, 2022

This is looking good now, thanks @sahil-R!

@sahil-R
Copy link
Contributor Author

sahil-R commented Dec 11, 2022

This is looking good now, thanks @sahil-R!

Hey @dhruvkb , Thank you for the update, can you suggest me another approver for these changes since it requires two approvals.

@dhruvkb dhruvkb requested review from a team and AetherUnbound and removed request for a team December 11, 2022 11:39
@dhruvkb
Copy link
Member

dhruvkb commented Dec 11, 2022

I tagged @WordPress/openverse-api on this issue, which picked @AetherUnbound as the second reviewer.

@dhruvkb dhruvkb added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Dec 11, 2022
@AetherUnbound AetherUnbound changed the title Improvement674 Update default accuracy to None to support null JSON values Update default accuracy to None to support null JSON values Dec 12, 2022
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @sahil-R! This looks good and can be merged as soon as we update the help text.

api/catalog/api/serializers/media_serializers.py Outdated Show resolved Hide resolved
@AetherUnbound AetherUnbound merged commit 202e035 into WordPress:main Dec 14, 2022
@sahil-R sahil-R deleted the improvement674 branch December 15, 2022 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove required attribute from unidirectional serializers
5 participants