This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Update default accuracy to None to support null JSON values #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
the
🚦 status: awaiting triage
Has not been triaged & therefore, not ready for work
label
Dec 6, 2022
dhruvkb
suggested changes
Dec 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the root Pipfile
and Pipfile.lock
. Both the api/
and ingestion_server/
have their Python environments in their directories.
sahil-R
requested review from
dhruvkb
and removed request for
sarayourfriend
December 11, 2022 11:29
sahil-R
changed the title
Improvement674
Improvement674 Update default accuracy to None to support null JSON values
Dec 11, 2022
dhruvkb
approved these changes
Dec 11, 2022
This is looking good now, thanks @sahil-R! |
dhruvkb
requested review from
a team and
AetherUnbound
and removed request for
a team
December 11, 2022 11:39
I tagged |
dhruvkb
added
✨ goal: improvement
Improvement to an existing user-facing feature
💻 aspect: code
Concerns the software code in the repository
🟩 priority: low
Low priority and doesn't need to be rushed
and removed
🚦 status: awaiting triage
Has not been triaged & therefore, not ready for work
labels
Dec 11, 2022
AetherUnbound
changed the title
Improvement674 Update default accuracy to None to support null JSON values
Update default accuracy to None to support null JSON values
Dec 12, 2022
AetherUnbound
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @sahil-R! This looks good and can be merged as soon as we update the help text.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
💻 aspect: code
Concerns the software code in the repository
✨ goal: improvement
Improvement to an existing user-facing feature
🟩 priority: low
Low priority and doesn't need to be rushed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #674 by @dhruvkb
Description
The issue stated that the serializers were not allowing null values to be passed on in the response JSON which is returned by the API,The code was running fine when tested however the accuracy were not accompanied with the tags which were added to the response,added the fix with default accuracy as None and edited the test cases for the same.
Testing Instructions
just do any API request and the output runs fine as usual with null values returned as well.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin