This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Various improvements to CONTRIBUTING.md #1009
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GUIDELINES.md, removed the lines about GitHub discussions.
…es link on line 12.
openverse-bot
added
📄 aspect: text
Concerns the textual material in the repository
🛠 goal: fix
Bug fix
🟨 priority: medium
Not blocking but should be addressed soon
labels
Nov 17, 2022
Yash-Pratapwar
changed the title
Fix: Issue 973
Did various improvements to CONTRIBUTING.md
Nov 17, 2022
dhruvkb
reviewed
Nov 17, 2022
Yes, will change that.
…On Thu, Nov 17, 2022, 09:51 Dhruv Bhanushali ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CONTRIBUTING.md
<#1009 (comment)>
:
> -### Proposing changes or new features
+### Questions or Thoughts?
-If you have an idea of a new feature or change to how the Openverse API works, please [start a discussion](https://github.com/WordPress/openverse-api/discussions/new?category=ideas) so we can discuss the possibility of that change or new feature being implemented and released in the future. This lets us come to an agreement about the proposed idea before any work is done.
+Feel free to [join us on Slack](https://make.wordpress.org/chat/) and discuss the project with the engineers and community members on #openverse.
The "Questions or Thoughts?" section is already present at the bottom of
the file. This section should be changed to suggestion opening an issue
because we now use issues for discussion as well.
—
Reply to this email directly, view it on GitHub
<#1009 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APWNCAQHVYYCQUCZXQSDBKDWIWXFVANCNFSM6AAAAAASC56SOU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…ges or discuss new features.
Yash-Pratapwar
requested review from
dhruvkb
and removed request for
AetherUnbound and
obulat
November 17, 2022 09:57
AetherUnbound
suggested changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! There is one change regarding the gitignore
that must be made, and I have a few other suggestions on top of that.
AetherUnbound
changed the title
Did various improvements to CONTRIBUTING.md
Various improvements to CONTRIBUTING.md
Nov 17, 2022
Co-authored-by: Madison Swain-Bowden <[email protected]>
Co-authored-by: Madison Swain-Bowden <[email protected]>
Yash-Pratapwar
requested review from
AetherUnbound
and removed request for
dhruvkb
November 18, 2022 11:24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very close, just a few more changes!
Co-authored-by: Madison Swain-Bowden <[email protected]>
…Pipfile from root directory.
AetherUnbound
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you @Yash-Pratapwar!
dhruvkb
approved these changes
Nov 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
📄 aspect: text
Concerns the textual material in the repository
🛠 goal: fix
Bug fix
🟨 priority: medium
Not blocking but should be addressed soon
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #973 by @Yash-Pratapwar
Description
This PR does various imrpovements to CONTRIBUTING.md file.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin