Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Various improvements to CONTRIBUTING.md #1009

Merged
merged 13 commits into from
Nov 22, 2022

Conversation

Yash-Pratapwar
Copy link
Contributor

@Yash-Pratapwar Yash-Pratapwar commented Nov 17, 2022

Fixes

Fixes #973 by @Yash-Pratapwar

Description

This PR does various imrpovements to CONTRIBUTING.md file.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Yash-Pratapwar Yash-Pratapwar requested a review from a team as a code owner November 17, 2022 04:19
@openverse-bot openverse-bot added 📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon labels Nov 17, 2022
@Yash-Pratapwar Yash-Pratapwar changed the title Fix: Issue 973 Did various improvements to CONTRIBUTING.md Nov 17, 2022
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Yash-Pratapwar
Copy link
Contributor Author

Yash-Pratapwar commented Nov 17, 2022 via email

@Yash-Pratapwar Yash-Pratapwar requested review from dhruvkb and removed request for AetherUnbound and obulat November 17, 2022 09:57
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! There is one change regarding the gitignore that must be made, and I have a few other suggestions on top of that.

.gitignore Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@AetherUnbound AetherUnbound changed the title Did various improvements to CONTRIBUTING.md Various improvements to CONTRIBUTING.md Nov 17, 2022
@Yash-Pratapwar Yash-Pratapwar requested review from AetherUnbound and removed request for dhruvkb November 18, 2022 11:24
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very close, just a few more changes!

.gitignore Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you @Yash-Pratapwar!

@dhruvkb dhruvkb merged commit 3479b8c into WordPress:main Nov 22, 2022
@Yash-Pratapwar Yash-Pratapwar deleted the issue_973 branch November 23, 2022 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various improvements to CONTRIBUTING.md
4 participants