Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Link for automated tests file broken in DOCUMENTATION_GUIDELINES.md #992

Closed
1 task done
Yash-Pratapwar opened this issue Oct 29, 2022 · 9 comments · Fixed by #1008
Closed
1 task done

Link for automated tests file broken in DOCUMENTATION_GUIDELINES.md #992

Yash-Pratapwar opened this issue Oct 29, 2022 · 9 comments · Fixed by #1008
Assignees
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@Yash-Pratapwar
Copy link
Contributor

Description

I clicked the link for automated tests file in DOCUMENTATION_GUIDELINES.md and instead of going to the appropriate location is says The 'WordPress/openverse-api' repository doesn't contain the '.github/workflows/integration-tests.yml' path in 'main'. I think the location of the file has been changed, If anyone could tell me the correct location I will be able to resolve this error.

Reproduction

  1. Go to DOCUMENTATION_GUIDELINES.md
  2. Navigate to How to Start Contributing
  3. Click on the link in the 3rd point under How to Start Contributing
  4. See error.

Screenshots

image

Environment

  • Device: Laptop
  • OS: Windows 10
  • Browser: Chrome
  • Version: 106.0.5249.119

Resolution

  • 🙋 I would be interested in resolving this bug.
@Yash-Pratapwar Yash-Pratapwar added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix labels Oct 29, 2022
@AetherUnbound
Copy link
Contributor

Great find! This should probably link to our CI/CD file instead now: https://github.com/WordPress/openverse-api/blob/main/.github/workflows/ci_cd.yml

@Yash-Pratapwar
Copy link
Contributor Author

Great find! This should probably link to our CI/CD file instead now: https://github.com/WordPress/openverse-api/blob/main/.github/workflows/ci_cd.yml

@AetherUnbound I will start working on it thanks!

@AetherUnbound AetherUnbound added good first issue New-contributor friendly help wanted Open to participation from the community 📄 aspect: text Concerns the textual material in the repository 🟩 priority: low Low priority and doesn't need to be rushed and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 1, 2022
@Yash-Pratapwar
Copy link
Contributor Author

@AetherUnbound I had one question about the contribution process, do I need to set-up anything or should I directly fork > create a new branch > do the changes > push it > create a PR?

@AetherUnbound
Copy link
Contributor

That's correct! You can see this from step 7 on in our contributing guide. You should only need to fork the repo once, but every new PR will require a new branch.

@Yash-Pratapwar
Copy link
Contributor Author

Yash-Pratapwar commented Nov 2, 2022 via email

@Yash-Pratapwar
Copy link
Contributor Author

@AetherUnbound where can I find the instructions to set up the environment?

@AetherUnbound
Copy link
Contributor

Hi @Yash-Pratapwar, please see the contributing guide for this repo: https://github.com/WordPress/openverse-api/blob/main/CONTRIBUTING.md. That document does need some updating for use with our command runner just, I'll make an issue for it.

@AetherUnbound
Copy link
Contributor

Ah, I found it 😄 #973 - and you've also offered to help there as well!

@Yash-Pratapwar
Copy link
Contributor Author

Yash-Pratapwar commented Nov 15, 2022 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants