Fix invalid UUID breaking related images query (#766)

* Return lower cased license after validation Signed-off-by: Olga Bulat <[email protected]> * Add tests Signed-off-by: Olga Bulat <[email protected]>
WordPress · Jun 23, 2022 · 32f5a21 · 32f5a21
1 parent 7414174
commit 32f5a21
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/api/catalog/api/views/media_views.py b/api/catalog/api/views/media_views.py
@@ -116,6 +116,9 @@ def related(self, request, identifier=None, *_, **__):
             self.paginator.page_size = 10
         except ValueError as e:
             raise get_api_exception(getattr(e, "message", str(e)))
+        # If there are no hits in the search controller
+        except IndexError:
+            raise get_api_exception("Could not find items.", 404)
 
         serializer = self.get_serializer(results, many=True)
         return self.get_paginated_response(serializer.data)

diff --git a/api/test/api_live_integration.py b/api/test/api_live_integration.py
@@ -446,6 +446,13 @@ def no_duplicates(xs):
     assert no_duplicates(ids)
 
 
+def test_related_does_not_break():
+    response = requests.get(
+        f"{API_URL}/image/related/000000000000000000000000000000000000", verify=False
+    )
+    assert response.status_code == 404
+
+
 @pytest.fixture
 def related_factory():
     """