Editor package: fix block settings menu appearance #9777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve the styling issue that were present in Gutenberg integrations that rely on published npm packages. Outside of wp-admin context the removed CSS line was causing the horizontal scrollbar to appear in block settings menu.
vindl
requested review from
jasmussen,
Copons,
gwwar,
gziolo and
youknowriad
vindl
added
[Type] Bug
jasmussen
approved these changes
Sep 11, 2018
There was a problem hiding this comment.
In #8756 we made it so menus can grow. I was sure thish PR would affect that, but it seems unrelated.
One of the challenges we have with menus is that plugins can add items, with very long titles, and translations can get even longer. It looks like we can still do better here:
But it seems like that issue is the same whether this rule is present or not. In other words, if this fixes an issue for you, ship it! Thanks for your PR.
|
Thanks for the review @jasmussen! |
|
Sure thing! Remember to add any merged PR to a milestone so we can build our changelogs properly @vindl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to resolve the styling issue that's present in Gutenberg integration that rely on
@wordpress/editorpackage and its CSS. The block settings menu was always shown with a horizontal scrollbar, and removing thewidth: 100%attribute from it resolved the issue, while at the same time preserving the existing look inwp-admin.How has this been tested?
I've verified that this fixes the issue in the Gutenberg integrations that we are working on: wp-calypso and standalone repository (to rule out the possibility of visual issues caused by Calypso shared styles).
After that I've tested the change in Gutenberg local development environment and
wp-admin, and made sure that the placeholder still looks the same.Screenshots
@wordpress/components:wp-admincontext.Types of changes
Bug fix (non-breaking change which fixes an issue).
Checklist: