Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust unified block toolbar padding at medium breakpoints. #9742

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Adjust unified block toolbar padding at medium breakpoints. #9742

merged 1 commit into from
Sep 10, 2018

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Sep 10, 2018

Fixes a visual bug where the block controls in Unified Toolbar are larger than their container bar on screens that are between 781px and 960px wide.

Fixes #9657.

To Test:

  1. Activate Unified Toolbar mode from the ellipsis menu.
  2. Scale your screen down so it's in between 781px and 960px wide.
  3. Select a block, and observe the way the block toolbar looks at the top of the screen.

Screenshots

Before:
screen shot 2018-09-10 at 9 22 28 am

After:
screen shot 2018-09-10 at 9 20 36 am

@kjellr
Move unified block toolbar padding to large breakpoints.
5d0978e 
Fixes a visual bug where the block controls in Unified Toolbar are larger than their container bar on screens that are between 781px and 960px wide.

Fixes #9657.
@kjellr kjellr added the [Type] Bug An existing feature does not function as intended label Sep 10, 2018
@kjellr kjellr added this to the 3.9 milestone Sep 10, 2018
@kjellr kjellr added the Mobile Web Viewport sizes for mobile and tablet devices label Sep 10, 2018
jasmussen
jasmussen approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, works for me! Nice!

@kjellr kjellr changed the title Move unified block toolbar padding to large breakpoints. Adjust unified block toolbar padding at medium breakpoints. Sep 10, 2018
@kjellr kjellr merged commit 9e56083 into master Sep 10, 2018
@kjellr
Copy link
Contributor Author

kjellr commented Sep 10, 2018

Thanks! 🙌

@kjellr kjellr deleted the fix/block-unified-toolbar-middle-breakpoints branch September 10, 2018 14:11
@yassine4999 yassine4999 mentioned this pull request Nov 30, 2023
Open
@soloinovator soloinovator mentioned this pull request Nov 30, 2023
Open
@petrescugit petrescugit mentioned this pull request Nov 30, 2023
Open
@captainbarber99 captainbarber99 mentioned this pull request Nov 30, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.9
Development

Successfully merging this pull request may close these issues.
2 participants
@kjellr @jasmussen