[Fix] Gallery losing columns when alignments are applied #9694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
approved these changes
Oct 8, 2018
|
Thank you so much for the review @jasmussen ❤️ |
|
Hi folks, are there any plans to merge this? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #9533 which reports that the "Gallery" block loses the assigned number of columns when alignments are applied.
How has this been tested?
This PR has been tested by going through the following steps:
Screenshots
Types of changes
This PR applies styles which keep the
displayproperty of the gallery block asflex(which makes the column functionality work) even if alignment settings are applied (which changes the value toblockandinline-blockin different cases).Checklist: