Fix focus rectangle regression #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also custom style the focus for editable toolbars.
We are likely going to need to tweak these further as we go, but for now going with the mockups.
jasmussen
added
the
General Interface
|
What are testing instructions? |
|
@joen Looks great. I'm getting two rectangles for toolbar buttons:
|
|
Ack sorry missed the two comments here. Testing instructions are tabbing through buttons, and verifying there's a focus rectangle. I'm going to have to remove the one on toolbar buttons, that's a regression, and I'm going to darken the outline a little bit also. |
|
I've updated this PR and now it should be good to review:
|
|
@jasmussen I'm still seeing two lines. Is this intended?
|
|
Argh, can't believe this took so long. Should finally be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a focus rectangle regression I introduced in a previous commit. In doing so, it's also starting work on #904. More work will need to be done, I suspect, and designs tuned, but this PR improves things.