Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates: Apply template for new post only #9288

Merged
merged 2 commits into from
Aug 24, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Aug 23, 2018

Related: #9287

This pull request seeks to resolve an issue where removing all blocks from a post with a template assigned would reintroduce the template blocks after saving and reloading the editor. This is in contrast with removal of a single block from template, where the edits would be respected.

It may be that we want to communicate to the user that the block content is in conflict with the template, or provide the option to insert the template for a truly-empty post, but the default behavior should respect the saved content of the user if they had removed the blocks in a previous session.

Testing instructions:

Verify that removing all blocks from a post with template, saving that post, and reloading the page, reflects that the blocks are still removed. I found this easiest by reusing the template plugin from within the test folder:

cd path/to/plugins
ln -s gutenberg/test/e2e/test-plugins/templates.php templates.php

Then activate the plugin from Plugins screen in administration. This will enable a new Books post type with a default template.

Ensure end-to-end tests pass:

npm run test-e2e

@aduth aduth added the [Feature] Templates API Related to API powering block template functionality in the Site Editor label Aug 23, 2018
@aduth aduth requested a review from youknowriad August 23, 2018 19:46
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@youknowriad
Copy link
Contributor

The e2e test breakage seems legitimate though

@aduth
Copy link
Member Author

aduth commented Aug 24, 2018

I renamed the test case and I guess forgot to update the snapshot. See c25fc3a.

@aduth aduth merged commit c28bc57 into master Aug 24, 2018
@aduth aduth deleted the fix/effect-template-new-post-only branch August 24, 2018 14:09
@jasmussen
Copy link
Contributor

I think this branch made it so the demo content no longer loads. Though note that the way I found this PR was not due to code changes, it was simply looking at https://github.com/WordPress/gutenberg/commits/master, and "Packages: Make usage of core-data explicit (#8911)" was the last commit where the demo content worked.

@aduth
Copy link
Member Author

aduth commented Aug 27, 2018

Thanks for the note @jasmussen . Will look into it shortly.

Related: We need an end-to-end test which simply loads the demo page. Though I suspect there are probably a fair number of other existing failures (console errors) which could cause the test to fail.

@aduth
Copy link
Member Author

aduth commented Aug 29, 2018

Created #9433 to track for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Templates API Related to API powering block template functionality in the Site Editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants