Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Block: Avoid scrollbars when shown full-width #8820

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

youknowriad
Copy link
Contributor

It looks like figures have margin by default which causes scrollbars if their content is 100% in full-width. This could be solved in several ways, so let me know what you think.

closes #8717

Testing instructions

  • Add an audio block
  • Make it full width
  • No scrollbars.

@youknowriad youknowriad added the [Feature] Blocks Overall functionality of blocks label Aug 10, 2018
@youknowriad youknowriad self-assigned this Aug 10, 2018
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Ship it!

Thank you for being mindful of horizontal scrollbars.

@youknowriad youknowriad merged commit 6627001 into master Aug 10, 2018
@youknowriad youknowriad deleted the fix/audio-block-scroll branch August 10, 2018 09:32
@mtias mtias added this to the 3.6 milestone Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio block: setting alignment to full width causes horizontal scroll
3 participants