Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inline comment that explains a stopPropagation() #8339

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Add inline comment that explains a stopPropagation() #8339

merged 1 commit into from
Aug 1, 2018

Conversation

noisysocks
Copy link
Member

Attempts to explain a call to event.stopPropagation() using an inline comment.

Fixes #6631 (comment).

@noisysocks noisysocks added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 31, 2018
@noisysocks noisysocks requested a review from aduth July 31, 2018 23:32
@noisysocks noisysocks mentioned this pull request Jul 31, 2018
Merged
gziolo
gziolo approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo gziolo added this to the 3.5 milestone Aug 1, 2018
@gziolo gziolo merged commit 7929c39 into master Aug 1, 2018
@gziolo gziolo deleted the add/inline-comment branch August 1, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@aduth aduth Awaiting requested review from aduth

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@noisysocks @gziolo