feat: Add SSL development option #8212
Conversation
tofumatt
changed the title
bin/install-docker.sh
Outdated
|
|
||
| # Wait until the docker containers are setup properely | ||
| echo -en $(status_message "Attempting to connect to wordpress...") | ||
| until $(curl -L http://localhost:$HOST_PORT -so - 2>&1 | grep -q "WordPress"); do | ||
| until $(curl -L --insecure $PROTOCOL://localhost:$HOST_PORT -so - 2>&1 | grep -q "WordPress"); do |
There was a problem hiding this comment.
In the future we should probably allow users to specify their hostname; I, for instance, find it handy to assign my Mac's local network name here instead of localhost for easier mobile/VM testing.
tofumatt
force-pushed
the
try/8211-ssl-option-local-env
branch
2 times, most recently
from
c280a3b
to
b9d745f
Compare
tofumatt
force-pushed
the
try/8211-ssl-option-local-env
branch
from
b9d745f
to
fbc9423
Compare
designsimply
added
the
[Type] Build Tooling
|
@ntwb I noticed your comment at #13441 (comment) saying you're interested in reviewing things about tooling and I was wondering if you'd like to help with this one? |
| @@ -6,6 +6,7 @@ services: | |||
| image: wordpress | |||
| ports: | |||
| - 8888:80 | |||
| - 9999:443 | |||
There was a problem hiding this comment.
Is the change of port required here, why not keep using 8888 and use 8888:443?
There was a problem hiding this comment.
I don't think it's required, I just did it so you'd know which version of the site you were working against during development. It's not usual in my experience to expect the protocol to change without the port changing. No reason it can't change though.
|
@designsimply Sure, it's late here, left a quick comment, I'll test this tomorrow and add some more feedback and/or approve :) |
|
@tofumatt - will you have some time to get it up to date or should someone take it over from here? |
|
I think it just needs a quick rebase but I don't really have the chance to get to it this week. It was originally related to #8164 which I noticed I was still assigned to but am not working on anymore, so I cleared assignment. Sorry 'bout that! |
gziolo
added
the
[Status] Stale
|
@WraithKenny - it looks like this PR won't get any further updates. Would you like to take over this issue and submit a patch based on your comment? I'm closing this PR to let others work on #8211. Thanks, @tofumatt on your initial work 😃 |
Description
Adds an SSL option for the local environment; the site can be accessed via
https://localhost:9999/and an--ssloption can be passed tosetup-local-env.shto make the SSL site the default.Fixes #8211.
Uses a self-signed certificate, because it's
localhost, but otherwise works great. Should be handy for testing mixed-content issues, etc.How has this been tested?
Ran locally; it worked. 😄