Ports the Paragraph Block to React Native #8149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
added
the
Mobile App - i.e. Android or iOS
gziolo
reviewed
Jul 24, 2018
packages/element/src/index.native.js
Outdated
| * | ||
| * @return {Function} Returns the new composite function. | ||
| */ | ||
| export { flowRight as compose }; |
There was a problem hiding this comment.
compose and createHigherOrderComponent were moved to compose package.
See: https://github.com/WordPress/gutenberg/blob/master/packages/compose/src/index.js
There was a problem hiding this comment.
I think we are still some commits behind in terms of a branch that is compatible with RN.
gziolo
reviewed
Jul 24, 2018
| return ( | ||
| <TextInput | ||
| multiline={ true } | ||
| value={ content[0] } |
There was a problem hiding this comment.
This file could use some whitespace formatting.
| }, | ||
| ]; | ||
|
|
||
| class ParagraphBlock extends Component { |
There was a problem hiding this comment.
We should move ParagraphBlock to its own file edit.js and override it rather than all paragraph settings.
SergioEstevao
changed the title
…h_block_port # Conflicts: # core-blocks/paragraph/index.js # packages/element/src/index.native.js
|
Closing in favor of #8231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the Paragraph Block using RN. This is still a stubbed version using the TextInput component.
How has this been tested?
No tests implemented.
Types of changes
Implements a native version of the Paragraph Block using a native version of the RichText component.
Checklist: