Framework: Rename MediaPlaceholder onSelectUrl prop as onSelectURL
#7982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
gziolo
approved these changes
Jul 17, 2018
| deprecated( 'MediaPlaceholder `onSelectUrl` prop', { | ||
| alternative: '`onSelectURL` prop', | ||
| plugin: 'Gutenberg', | ||
| version: 'v3.4', |
There was a problem hiding this comment.
3.5 to match with others? Whatever we decide 😄
aduth
force-pushed
the
rename/media-placeholder-on-select-url
branch
from
3c7bdaf to
c078d55
Compare
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to effect new capitalization guidelines around abbreviations (#7670) toward an API freeze. It deprecates the
onSelectUrlprop of thewp.editor.MediaPlaceholdercomponent in favor of the correctedonSelectURLnaming.Testing instructions:
Verify that there are no regressions in the use of the media placeholder (e.g. audio or video block URL input).
Ensure that
onSelectUrlprop works unaffected, but logs a deprecated warning.