-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix colspan bug in table block for tables with <thead> tags #7899
Conversation
I'm afk for a bit so you might want to expand the review range if you'd like a prompt review, but as a sanity check and without testing, this seems good. However you need to be sure to test both the options for fixed width cells in the inspector, and verify that the responsiveness works, that is there is a horizontal scroll bar if there's content on mobile that can't wrap. |
Thanks, no rush. I'm just working through some of the block conversion issues to try to whittle those down ahead of Try Gutenberg. I'll test out some more fixed-width cell scenarios to make sure they work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, removing display: table; from .wp-block-table tbody does fix the table display in the editor
Ah, good catch. Sorry about that. Looks like instead of removing |
@jasmussen Should I open a new PR with the fix or consolidate to #8767? |
I don't think a fix is urgent. If we know how to fix it, so long as it's on someone's radar or tracked, either is fine. Thanks |
If you have a recommended fix, I can put together a PR. |
This PR fixes table block regressions introduced in #7899 (comment) The block property for the table makes sure that it's mobile responsive. The "display table" is necessary for fixed layout to work.
* Fix table regressions. This PR fixes table block regressions introduced in #7899 (comment) The block property for the table makes sure that it's mobile responsive. The "display table" is necessary for fixed layout to work. * Address feedback: include thead, tfoot * Fix collapsed on init table. * Fix fixed-width cells.
Fixes: #7688
Removing
display: table
from thetbody
tag in the table block appears to solve the issue. I didn't see any negative effects from this in my testing, but it could use some additional testing to make sure there isn't a scenario I didn't come across.Tagging @jasmussen since he added this line originally in 24011e3 in case it's required for something.
Checklist: