Framework: Drop deprecations slated for 3.1 removal #7419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
gziolo
reviewed
Jun 21, 2018
| @@ -50,15 +50,6 @@ export function reinitializeEditor( postType, postId, target, settings, override | |||
| * @return {Object} Editor interface. | |||
| */ | |||
| export function initializeEditor( id, postType, postId, settings, overridePost ) { | |||
| if ( 'production' !== process.env.NODE_ENV ) { | |||
| // Remove with 3.0 release. | |||
|
I removed PHP part with 8bf8d21. @youknowriad can you double check if we didn't miss anything? |
gziolo
approved these changes
Jun 21, 2018
|
One more commit added 818acd1. Removed deprecated utils :) |
gziolo
added
the
[Priority] High
aduth
commented
Jun 21, 2018
|
|
||
| // viewport | ||
| export function isExtraSmall() { | ||
| originalDeprecated( 'wp.utils.isExtraSmall', { |
There was a problem hiding this comment.
Unfortunately the custom ESLint rule is not smart enough to capture anything except the default function name deprecated 😅
There was a problem hiding this comment.
Right, I was too creative renaming its name :)
This was referenced Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to remove deprecations slated for removal in the upcoming 3.1.0 release.
Specifically, this includes:
wp.blocks.*are removed. Please usewp.editor.*instead.wp.blocks.withEditorSettingsis removed. Please use the data module to access the editor settingswp.data.select( "core/editor" ).getEditorSettings().wp.utils.*are removed. Please usewp.dom.*instead.isPrivate: truehas been removed from the Block API. Please usesupports.inserter: falseinstead.wp.utils.isExtraSmallfunction removed. Please usewp.viewport.isExtraSmallinstead.getEditedPostExcerptselector removed (core/editor). UsegetEditedPostAttribute( 'excerpt' )instead.See: https://wordpress.org/gutenberg/handbook/reference/deprecated/#3-1-0
Testing instructions:
Verify that there are no regressions in impacted behavior, and importantly that no references to deprecated behaviors exist in core code.
Notably, test the excerpt field, which had not been previously upgraded until this pull request.