Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: Avoid returning prototype member from getEditedPostAttribute #7380

Closed
wants to merge 2 commits into from
Closed

Store: Avoid returning prototype member from getEditedPostAttribute #7380

wants to merge 2 commits into from

Conversation

aduth
Copy link
Member

@aduth aduth commented Jun 19, 2018

This pull request seeks to improve the getEditedPostAttribute, avoiding wasteful calls to getPostEdits where it is not intended to be used, and improves a case where the wrong return value may be returned for object prototype members.

Testing instructions:

Ensure unit tests pass:

npm run test-unit editor/store/test/selectors.js

@aduth aduth added the [Type] Code Quality Issues or PRs that relate to code quality label Jun 19, 2018
@aduth
Copy link
Member Author

aduth commented Jun 20, 2018

Superseded by #7130

@aduth aduth closed this Jun 20, 2018
@aduth aduth deleted the update/get-edited-attribute branch June 20, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aduth