Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State: Trigger autosave as standard save for draft by current user #7130

Merged
merged 11 commits into from
Jun 20, 2018
Merged

State: Trigger autosave as standard save for draft by current user #7130

merged 11 commits into from
Jun 20, 2018

Commits on Jun 20, 2018

  1. State: Trigger autosave as standard save for draft by current user

    @aduth
    aduth committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    01520b4 View commit details
    Browse the repository at this point in the history

  2. Testing: Update E2E tests for expected autosave conditions

    @aduth
    aduth committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    d817ec1 View commit details
    Browse the repository at this point in the history

  3. Testing: Wait for animation to avoid cursor chasing button

    @aduth
    aduth committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    08afec7 View commit details
    Browse the repository at this point in the history

  4. State: Distinguish save on effective autosave 

    Change detection reset for known-to-be-draft, pick from non-effective autosave for resetting post
    @aduth
    aduth committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    da5d327 View commit details
    Browse the repository at this point in the history

  5. Testing: Ensure autosave is identified as autosave 

    Passed previously because when autosaving, class is assigned with _both_ `is-saving` and `is-autosaving`. The superset of classes is what what should be expected.
    @aduth
    aduth committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    8f82de8 View commit details
    Browse the repository at this point in the history

  6. State: Update post in autosave as assumed full save

    @aduth
    aduth committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    df6f471 View commit details
    Browse the repository at this point in the history

  7. Preview: Enable published posts preview (#7189) 

    * REST API: Move preview_link to autosaves controller

* Post Preview: Redirect to preview by autosave property availability

* Preview Button: Use preview link as href if available

* Preview Button: Move window bind to after write

Was not reliably triggered when redirect occurs by setPreviewWindowLink, possibly because document.open triggered by document.write erased window handlers.

* Preview Button: Always trigger autosave when dirty

* Preview Button: Consider preview ready by change in value

* State: Set default value for savePost options

Allows use in handlers to assume options present

* Store: Clarify preview link with query parameter

* REST API: Set preview link by parent only if autosave

* Store: Invalid autosave preview link on save intent

Preview link is no longer valid until autosave completes, by which UI can infer availability of preview as being ready to view.

* Testing: Add preview E2E tests

* Testing: Fix copypasta

* Preview: Use correct location property for URL comparison
    @aduth
    aduth committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    5e9e1ca View commit details
    Browse the repository at this point in the history

  8. State: Partially pick saved fields for autosave 

    Must dirty artificially once save completes if there were edits not included in the payload.
    @aduth
    aduth committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    6fa254e View commit details
    Browse the repository at this point in the history

  9. Testing: Update published change detection test to use publishPost ut… 

    …ility
    @aduth
    aduth committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    ae15eca View commit details
    Browse the repository at this point in the history

  10. REST API: Fix code styling (aligned assignment operator)

    @aduth
    aduth committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    9f48e1a View commit details
    Browse the repository at this point in the history

  11. Autosave: Remove redundant draft transition of reset autosave 

    Now reflected in committed updatePost edit of status to draft in save effect for auto-draft (by current user).
    @aduth
    aduth committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    d974414 View commit details
    Browse the repository at this point in the history