Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getWPAdminUrl function to actually return the /wp-admin/ URL #7096

Closed
wants to merge 6 commits into from
Closed

Fix getWPAdminUrl function to actually return the /wp-admin/ URL #7096

wants to merge 6 commits into from

Commits on Jun 4, 2018

  1. Add _wpAdminURL as global variable

    @mkaz
    mkaz committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    013c5b3 View commit details
    Browse the repository at this point in the history

  2. Check if _wpAdminURL is defined and return in getWPAdminURL

    @mkaz
    mkaz committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    d1e333e View commit details
    Browse the repository at this point in the history

  3. Switch from using global to use editorSettings

    @mkaz
    mkaz committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    557a5ea View commit details
    Browse the repository at this point in the history

  4. Lint sigh.

    @mkaz
    mkaz committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    bf61251 View commit details
    Browse the repository at this point in the history

  5. Switch getWPAdminURL to be a @wordpress/utils function out of editor

    @mkaz
    mkaz committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    565f6b6 View commit details
    Browse the repository at this point in the history

  6. One day I'll remember to run lint/test prior to commit. One day.

    @mkaz
    mkaz committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    ace7d9f View commit details
    Browse the repository at this point in the history