Scripts: Use fork of rtlcss-webpack-plugin to fix issues with deps
#68201
+85
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Tool] WP Scripts
This was referenced Dec 20, 2024
gziolo
requested review from
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This is ready for review. As a follow-up, it would be a perfect time to introduce some integration tests for the default webpack config shipped with |
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in ecf479b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12434667306
|
gziolo
added
the
Good First Review
manzoorwanijk
approved these changes
Dec 24, 2024
I would prefer internally only, hoping that upstream version gets updated in the future. Other projects can always use |
|
I actually made a fork of this plugin here where all dependencies are updated and it's rewritten in TypeScript. I think this would be better to use rather than internally bundling a modified version of the plugin. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #62007.
Fixes #67866.
The
@babel/runtimedependency is limited to v6.25.x forrtclcss-webpack-pluginwhich causes issues.As noted by @mamzoorwanjik in #67866 (comment):
The same dependency was reported as problematic by @stein2nd in #62007.
Why?
No new version has been published for
rtlcss-webpack-pluginfor the last 3 years. There are open PRs for both dependencies with no activity.How?
Fork and simplify the plugin so integrates seamlessly with the default webpack config for
wp-scripts buildandwp-scripts start.Testing Instructions
It definitely can be tested manually by running the build for the scaffolded block: